| commit | 880218361c10d6dd7f99423d621112b8770fc32f | [log] [tgz] |
|---|---|---|
| author | Sean Christopherson <[email protected]> | Wed Jul 26 13:29:20 2023 -0700 |
| committer | Paolo Bonzini <[email protected]> | Sat Jul 29 11:05:31 2023 -0400 |
| tree | 42d92ee1f56db40e98f7f4277c513ee98df448ed | |
| parent | 211c0189ea18648a0cf23dea9f4ed745bc9252f6 [diff] |
Revert "debugfs, coccinelle: check for obsolete DEFINE_SIMPLE_ATTRIBUTE() usage" Remove coccinelle's recommendation to use DEFINE_DEBUGFS_ATTRIBUTE() instead of DEFINE_SIMPLE_ATTRIBUTE(). Regardless of whether or not the "significant overhead" incurred by debugfs_create_file() is actually meaningful, warnings from the script have led to a rash of low-quality patches that have sowed confusion and consumed maintainer time for little to no benefit. There have been no less than four attempts to "fix" KVM, and a quick search on lore shows that KVM is not alone. This reverts commit 5103068eaca290f890a30aae70085fac44cecaf6. Link: https://lore.kernel.org/all/[email protected] Link: https://lore.kernel.org/all/[email protected] Link: https://lkml.kernel.org/r/20230706072954.4881-1-duminjie%40vivo.com Link: https://lore.kernel.org/all/[email protected] Link: https://lore.kernel.org/all/Y2ENJJ1YiSg5oHiy@orome Link: https://lore.kernel.org/all/[email protected] Suggested-by: Paolo Bonzini <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Sean Christopherson <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>